Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove lib-cov/http dependency in index.js #136

Merged
merged 1 commit into from
Jan 20, 2017
Merged

remove lib-cov/http dependency in index.js #136

merged 1 commit into from
Jan 20, 2017

Conversation

bartw
Copy link
Contributor

@bartw bartw commented Dec 27, 2016

Solution for issue #117

@meeber
Copy link
Contributor

meeber commented Dec 28, 2016

Thanks @bartw! LGTM! @keithamus?

meeber
meeber approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@meeber meeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @keithamus

vieiralucas
vieiralucas approved these changes Jan 20, 2017
View reviewed changes
Copy link
Member

@vieiralucas vieiralucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@meeber Can I merge? Do you have an specific reason to wait for @keithamus here?

@meeber
Copy link
Contributor

meeber commented Jan 20, 2017

Merge away!

@vieiralucas vieiralucas merged commit ffe1f62 into chaijs:master Jan 20, 2017
@vieiralucas vieiralucas mentioned this pull request Jan 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vieiralucas vieiralucas vieiralucas approved these changes

@meeber meeber meeber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartw @meeber @vieiralucas