Fix 178 #184
Merged
Fix 178 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiralucas
reviewed
Oct 30, 2017
meeber
reviewed
Oct 31, 2017
lib/request.js
Outdated
| @@ -241,7 +259,7 @@ module.exports.agent = TestAgent; | |||
| * @api private | |||
| */ | |||
|
|
|||
| function Test (app, method, path) { | |||
| function Test (app, method, path, onFinish) { | |||
There was a problem hiding this comment.
I believe he was going to use it as a callback, but ended up going with the on('end' approach.
Anyways it looks like this parameter is not being used and should be removed 😄
There was a problem hiding this comment.
Oops 😊 yeah my original implementation had onFinish but then I realised I can use .on. Will remove.
This automatically closes server connections after making a request; so that test runners (like mocha 4) aren't left hanging after the test execution. If someone really needs to keep the server open, `.keepOpen()` can be used. Fixes #178 BREAKING CHANGE: This change closes servers down after every request. If you want to use the server for reasons at the same time as your test suite or for some other reason you dont want the server to automatically be shut-down, then you'll need to change any `chai.request` callsites to also use the `keepOpen` comand, like so: ```js chai.request(server).keepOpen() ```
|
README changes added |
meeber
approved these changes
Oct 31, 2017
|
@vieiralucas for another +1 and merge 😄 |
vieiralucas
approved these changes
Oct 31, 2017
|
@keithamus can you make the release? |
|
Yup - few bits to do before we make the release. I'll raise some more PRs shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparing for a release I noticed the severity of #178 was affecting our own test suite, so I decided to fix it. The commit description should hopefully provide context: