Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Update to superagent^9 #317

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[TASK] Update to superagent^9 #317

merged 1 commit into from
Apr 25, 2024

Conversation

thomashohn
Copy link
Contributor

No description provided.

@thomashohn thomashohn mentioned this pull request Apr 24, 2024
Closed
keithamus
keithamus approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Second approval+merge from @chaijs/chai-http or @chaijs/core would be great.

43081j
43081j approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

ill open a separate issue to move this package to using classes

@koddsson koddsson merged commit 6b50e3d into chaijs:main Apr 25, 2024
4 checks passed
@WontonSam WontonSam mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@koddsson koddsson koddsson approved these changes

@43081j 43081j 43081j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomashohn @keithamus @koddsson @43081j