Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chai 4.3.5 does not build on skypack #1466

Closed
tnguyen14 opened this issue Apr 24, 2022 · 3 comments
Closed

chai 4.3.5 does not build on skypack #1466

tnguyen14 opened this issue Apr 24, 2022 · 3 comments

Comments

@tnguyen14
Copy link

Starting with version 4.3.5, chai does not work with skypack https://cdn.skypack.dev/error/build:chai@v4.3.5-cdXlwD9j8XSpMk0e1GrE

I think this has to do with the change in esm exports, though I don't know enough about esm to figure out why. I'm sorry that I'm not able to articulate more intelligently why this issue is important, I don't know if others are using skypack. I just wonder if this is indicative of a deeper issue with ESM support.
@RebeccaStevens
Copy link

#1450

@jonkoops
Copy link

jonkoops commented Jan 2, 2024

This has been fixed in v5.

@43081j
Copy link
Contributor

43081j commented Jan 2, 2024

indeed seems to work now as of 5.x, closing this

@43081j 43081j closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonkoops @tnguyen14 @43081j @RebeccaStevens