Deep equality check in oneOf #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
=======================================
Coverage 94.61% 94.62%
=======================================
Files 33 33
Lines 1708 1711 +3
Branches 416 417 +1
=======================================
+ Hits 1616 1619 +3
Misses 92 92
Continue to review full report at Codecov.
|
keithamus
approved these changes
Feb 4, 2021
This was referenced Mar 3, 2021
keithamus
pushed a commit
that referenced
this pull request
Mar 3, 2021
The changes made in #1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai.
keithamus
added a commit
that referenced
this pull request
Feb 7, 2023
* Fixed a regression that caused SyntaxErrors on IE 11 The changes made in #1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai. * chai@4.3.2 * export chai.Assertion (#1378) * chai@4.3.3 * fix: support inspecting bigints (#1321) (#1383) * 4.3.4 * feat: use chaijs/loupe for inspection (#1401) (#1407) Fix #1228 * fix: package.json - deprecation warning on exports field (#1400) * fix package.json exports * build(deps-dev): bump codecov from 3.1.0 to 3.7.1 (#1446) Bumps [codecov](https://github.com/codecov/codecov-node) from 3.1.0 to 3.7.1. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-node@v3.1.0...v3.7.1) --- updated-dependencies: - dependency-name: codecov dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build chaijs * 4.3.5 * fix: use loupe@^2.3.1 * build chaijs * 4.3.6 * fix: deep-eql bump package to support symbols comparison (#1483) * 4.3.7 * build * chore: 4.x.x: Fix link to commit logs on GitHub (#1487) * 4.x.x: Fix link to commit logs on GitHub As there is no `master` branch, the link returned a 404. * Update History.md Co-authored-by: Andre Meyering <info@andremeyering.de> Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> * build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (#1488) Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: fix typo in test.js (#1459) * docs: specify return type of objDisplay (#1490) previously it was incorrectly labeled as `objDisplay(obj: object): void` in `@types/chai`. * feat: rework into ES modules This moves all of the sources to be ES modules rather than CommonJS. In order to produce the entrypoints, we use esbuild as a bundler (and as a transpiler in a way). Due to the fact that some dependencies are written in CommonJS, we actually use esbuild to create _two_ bundles: a CommonJS bundle, and an ES module bundle. Otherwise, someone importing the raw source would inevitably end up trying to import a CommonJS module somewhere down the tree, which would not work in browsers natively. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Lee Newson <lnewso@hotmail.com> Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> Co-authored-by: rbruckheimer <rob@cosaic.io> Co-authored-by: Mike Frysinger <vapier@gmail.com> Co-authored-by: Pascal Corpet <pcorpet@users.noreply.github.com> Co-authored-by: Mimi <stevenjoezhang@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Newcomer <snewcomer@users.noreply.github.com> Co-authored-by: Andre Meyering <info@andremeyering.de> Co-authored-by: Mavaddat Javid <5055400+mavaddat@users.noreply.github.com> Co-authored-by: scarf <greenscarf005@gmail.com> Co-authored-by: James Garbutt <james.garbutt@crispthinking.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #1241 it was noted that
.oneOfgives an unexpected result when attempting deep comparisons, and it turns out that.oneOfdoes not check for thedeepflag. Since this is already an existing option for.equal, it would make sense to extend this behavior to its counterpart in.oneOf.Fixes #1241.