Revert .empty assertion change from PR #499 #538

Merged
merged 1 commit into from Oct 21, 2015

Projects

None yet

2 participants

@tusbar
Contributor
tusbar commented Oct 21, 2015

The change introduced in #499 breaks compatibility with Array-like objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix #537

cc @keithamus

@tusbar tusbar Revert .empty assertion change from PR #499
The change introduced in #499 breaks compatibility with Array-like
objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix #537
8c1d8cf
@keithamus keithamus merged commit 1b2c648 into chaijs:master Oct 21, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@keithamus
Member

I'll cut this as 3.4.0 as new features have been introduced since the last merge. If I can find the time I'll also try to rustle up a 3.3.1 which patches just this against 3.3.0.

@tusbar tusbar deleted the tusbar:tusbar/revert-499 branch Oct 21, 2015
@tusbar
Contributor
tusbar commented Oct 21, 2015

👍

@marekventur marekventur referenced this pull request in Gamevy/pixi-packer Dec 14, 2015
Merged

Update "chai" to version ^3.4.1 #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment