New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert .empty assertion change from PR #499 #538

Merged
merged 1 commit into from Oct 21, 2015

Conversation

Projects
None yet
2 participants
@tusbar
Contributor

tusbar commented Oct 21, 2015

The change introduced in #499 breaks compatibility with Array-like objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix #537

cc @keithamus

Revert .empty assertion change from PR #499
The change introduced in #499 breaks compatibility with Array-like
objects (e.g. mongoose arrays).
It should be applied in the next major version.

Fix #537

keithamus added a commit that referenced this pull request Oct 21, 2015

Merge pull request #538 from tusbar/tusbar/revert-499
Revert .empty assertion change from PR #499

@keithamus keithamus merged commit 1b2c648 into chaijs:master Oct 21, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Oct 21, 2015

Member

I'll cut this as 3.4.0 as new features have been introduced since the last merge. If I can find the time I'll also try to rustle up a 3.3.1 which patches just this against 3.3.0.

Member

keithamus commented Oct 21, 2015

I'll cut this as 3.4.0 as new features have been introduced since the last merge. If I can find the time I'll also try to rustle up a 3.3.1 which patches just this against 3.3.0.

@tusbar tusbar deleted the tusbar:tusbar/revert-499 branch Oct 21, 2015

@tusbar

This comment has been minimized.

Show comment
Hide comment
@tusbar

tusbar Oct 21, 2015

Contributor

👍

Contributor

tusbar commented Oct 21, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment