New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add `.own.include` and `.nested.include` #926

Merged
merged 1 commit into from Feb 7, 2017

Conversation

Projects
None yet
3 participants
@meeber
Contributor

meeber commented Feb 2, 2017

Adds missing tests as noted in #905 and already documented in #920.

@lucasfcosta

Awesome job! LGTM!

Also, I noticed that our coverage badge isn't really working. As you can see in this link the most recent builds happened in 2015!

I think it's worth fixing since the coverage at the time was kind of low and it would be good for us to get a more precise report.

Anyway, let's get this one merged and open a separate issue for that.

@vieiralucas

LGTM!

@vieiralucas vieiralucas merged commit f937ee5 into chaijs:master Feb 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@meeber meeber deleted the meeber:missing-include-tests branch Aug 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment