Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests for anonymous functions on IE #6

Merged
merged 1 commit into from
Jun 6, 2016
Merged

fix: tests for anonymous functions on IE #6

merged 1 commit into from
Jun 6, 2016

Conversation

lucasfcosta
Copy link
Member

This fixes tests for IE9 and above.
The problem was that IE was returning ' ' for anonymous functions and therefore it didn't match ''.
This also fixes errors regarding poorly-constructed errors, because ' ' would not evaluate to false and therefore we couldn't do getConstructorName(new errorLike()) and this would fail too.

Here we go 🎉

@meeber
Copy link

meeber commented Jun 6, 2016

LGTM Professor @lucasfcosta

@coveralls
Copy link

coveralls commented Jun 6, 2016

Coverage Status

Changes Unknown when pulling a219c3f on lucasfcosta:fix-anonymous-functions-ie into * on chaijs:master*.

@keithamus
Copy link
Member

LGTM!

@keithamus keithamus merged commit d257b86 into chaijs:master Jun 6, 2016
@lucasfcosta
Copy link
Member Author

lucasfcosta commented Jun 6, 2016

Build is passing the first time it was ran, the other builds have timed out since they received no output for 10 minutes.
You can see logs here, unfortunately I don't have permissions to restart the build.

The same thing happened last time we got this published, I think it may be an issue with running them all at the same time or some specific proxy settings, but I'd need more time to investigate it and find the real cause for this.
For now, would any of you mind restarting the build please?


EDIT:
Just ran into this issue.
It may solve our problems. What do you guys think? Should I raise a PR for that? I'm not very confident it is stable and it will work, since the only way to test it is to merge and wait for the build to run successfully, but I can do it.

@meeber
Copy link

meeber commented Jun 6, 2016

@lucasfcosta I'm not able to either

@keithamus
Copy link
Member

I'm not sure why neither of you are able to restart the build - I've restarted it anyway.

The config we have here should be working - its the same config deep-eql has, and the same chai has I believe. It could be a case that we're hitting the limit of simultaneous VMs being run on that Saucelabs account.

At any rate while I've been typing this, it looks like the build has passed. check-error@1.0.1 has been released 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants