Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random condition in chainerx.where test #8342

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Fix random condition in chainerx.where test #8342

merged 2 commits into from
Nov 13, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Oct 30, 2019

Previously it was always an all-false array.

@niboshi niboshi added the cat:test Test or CI related. label Oct 30, 2019
@asi1024 asi1024 self-assigned this Oct 30, 2019
@asi1024
Copy link
Member

asi1024 commented Oct 30, 2019

Jenkins, test this please.

@niboshi
Copy link
Member Author

niboshi commented Oct 30, 2019 •
edited
Loading

After this fix #8316 does not occur for 10,000 runs (with exactly the same parameter).
I don't know how this fix is effective, though.

@niboshi niboshi mentioned this pull request Oct 30, 2019
Closed
@asi1024 asi1024 added this to the v7.0.0 milestone Oct 30, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1a80b98, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member

asi1024 commented Oct 31, 2019

Jenkins, test this please.

@niboshi
Copy link
Member Author

niboshi commented Oct 31, 2019

test_where_scalar_scalar failed because different cond arrays were sampled for numpy and chainerx, in combination with @chainerx.testing.numpy_chainerx_array_equal.
Fixed _random_condition to accept a fixed random state.

PTAL.

@asi1024
Copy link
Member

asi1024 commented Oct 31, 2019

flexCI, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 9909222, target branch master) failed with status FAILURE.

@niboshi
Copy link
Member Author

niboshi commented Oct 31, 2019

The Jenkins failure does not seem related. It occurs in master too (like once in 100,000 runs).

18:16:38 FAIL ../../../repo/tests/chainerx_tests/unit_tests/routines_tests/test_linalg.py::test_CholeskyFailing_param_7_{in_dtypes='float64', shape=(6, 6)}[cuda:0]

18:16:37 E       numpy.linalg.LinAlgError: Matrix is not positive definite

@asi1024 asi1024 mentioned this pull request Nov 1, 2019
Closed
@emcastillo emcastillo mentioned this pull request Nov 5, 2019
Closed
@asi1024
Copy link
Member

asi1024 commented Nov 13, 2019

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 9909222, target branch master) succeeded!

@asi1024
Copy link
Member

asi1024 commented Nov 13, 2019

LGTM.

@asi1024 asi1024 merged commit 59df4d0 into chainer:master Nov 13, 2019
@asi1024 asi1024 added the to-be-backported Pull request that should be backported. label Nov 13, 2019
@niboshi niboshi deleted the test-where-condition branch November 13, 2019 09:49
@asi1024 asi1024 removed the to-be-backported Pull request that should be backported. label Nov 13, 2019
@hvy hvy mentioned this pull request Dec 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asi1024 asi1024 asi1024 approved these changes

Assignees

@asi1024 asi1024

Labels
cat:test Test or CI related.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@niboshi @asi1024 @chainer-ci