Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResidualDQN's training #402

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Fix ResidualDQN's training #402

merged 1 commit into from
Feb 24, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Feb 24, 2019

#317 broke ResidualDQN's training and made tests/agents_tests/test_residual_dqn.py fail. This PR fixes it.

prabhatnagarajan
prabhatnagarajan approved these changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@muupan muupan merged commit 0ad044a into chainer:master Feb 24, 2019
@muupan muupan deleted the fix-residual-dqn branch February 24, 2019 15:05
@muupan muupan mentioned this pull request Feb 24, 2019
Open
@muupan muupan modified the milestone: v0.6 Feb 26, 2019
@muupan muupan added the bug label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @prabhatnagarajan