spdx: allow specifying custom license #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If licenserefs are passed, include them in the SPDX document. Related: chainguard-dev/melange#1212 Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@chainguard.dev>
imjasonh
approved these changes
May 16, 2024
imjasonh
reviewed
May 16, 2024
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@chainguard.dev>
xnox
added a commit
to xnox/apko
that referenced
this pull request
May 20, 2024
This fixes chainguard-dev#1127 With package SBOMs now containing custom license information (i.e. font-ubuntu), teach Image SBOM generator to merge those. Error out if two packages use the same licence-ref but with different extracted license text, as that would be an invalid SBOM merge. This feels nicer than force renaming licenseIDs with multiple duplicate texts. Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If licenserefs are passed, include them in the SPDX document.
Related: chainguard-dev/melange#1212
Signed-off-by: Dimitri John Ledkov dimitri.ledkov@chainguard.dev