Enable pubsub tracing #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Tran <tcnghia@gmail.com>
Signed-off-by: Nghia Tran <tcnghia@gmail.com>
imjasonh
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
googclient-traceparentto be progapated to push subscribers. We can also populate this ourselves (by setting a message attribute), but the library also adds a couple nice spans inside to the pubsub client librarytraceparentbygoogclient-traceparentif availableThis PubSub client library is at 1.37, slightly older than our current version (1.38). According to googleapis/google-cloud-go#4665 (comment) this will be launching ~soonish so we won't have to use an older version much longer. If it takes very long, we can DIY.