Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec_test: don't emit output #73

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

imjasonh
Copy link
Member

Storing up to 1KB of output for each exec in TF state makes it unnecessarily large and unnecessarily slow to marshal/unmarshal.

If you want to check details of the output, you can do that with existing tools inside the shell environment.

This output was also used by our own provider tests to check that free ports worked, but that's no reason to keep it around. The free port test still heuristically checks that N simultaneous free-ported docker runs don't conflict, which is probably good enough.

Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh merged commit 421ca53 into chainguard-dev:main Sep 12, 2023
8 checks passed
@xnox
Copy link

xnox commented Mar 26, 2024

So this means that none of our test cases ever produce any output that one can later audit. Is it possible to use like output terraform module to store the test results somewhere else? Or does even output stuff end up being serialized inside the terraform state file?

@mattmoor
Copy link
Member

output is serialized into state :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants