Skip to content

chore(oci registry): show validation error during save #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

chore(oci registry): show validation error during save #106

merged 1 commit into from
May 5, 2023

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented May 5, 2023 •
edited
Loading

During OCI registry save, we now

  • Capture and returns validation error with plain message instead of generic 500 error
  • Do not send an exception to sentry in that case

Before (CLI output)

ERR server error

After

ERR invalid repository URI: repository can only contain the characters `abcdefghijklmnopqrstuvwxyz0123456789_-./`: [REPO_URI]

Closes #105

@migmartri
chore: show validation error
cee333f 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri changed the title chore: show validation error chore(oci registry): show validation error during save May 5, 2023
@migmartri migmartri merged commit 477087c into chainloop-dev:main May 5, 2023
@migmartri migmartri deleted the 105-oci-validation-error branch May 5, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handle invalid error during the OCI registry registration
1 participant
@migmartri