refactor(config): extract secret manager configuration #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
May 27, 2023
migmartri
commented
May 27, 2023
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
gr0
approved these changes
May 29, 2023
|
Thanks for the review!
…On Mon, May 29, 2023, 3:25 PM Rafał Kuć ***@***.***> wrote:
***@***.**** approved this pull request.
👍 I like the simplification and putting the code responsible for
initialization in a single place.
—
Reply to this email directly, view it on GitHub
<#133 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF7SYKO5JM6Q2EZ4MZFULXISPUHANCNFSM6AAAAAAYRHZB5Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
danlishka
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the control plane and the CAS use the same way to configure and initialize the
secretsbackend. This code extracts this to the parent module, specifically:Note that this does not have any impact in the external UX of an user.
cc/ @gr0
Refs #108