feat: Add support for JUnit XML material type (#120) #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
…dded tests Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
…o mod tidy Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
danlishka
commented
May 30, 2023
…efactoring Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
…evert the comment change Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
danlishka
changed the title
migmartri
approved these changes
May 31, 2023
…pply feedback from the PR review Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
…pply feedback from the PR review, remove unnecessary tests Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
…pply feedback from the PR review Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
…pply feedback from the PR review Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
migmartri
reviewed
May 31, 2023
…pply feedback from the PR review Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for a new material type: JUnit XML.
We know that more types will be added in the future, so I propose to extract the upload&craft code and move it to a new reusable private function uploadAndCraft. All similar materials, such as SBOMs (SPDX, CycloneDX), Artifact, and more, may use this function instead of duplicating the code in the Craft method.
Documentation is updated in this PR chainloop-dev/docs#126
closes #120