Skip to content

Conversation

danlishka
Copy link
Member

@danlishka danlishka commented Jun 13, 2023

Choose the random port for HTTP Metrics in the development mode to fix the already-in-use port issues on OSX, closes #155

…to fix the already-in-use port issues on OSX, refs chainloop-dev#155

Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
@danlishka danlishka requested a review from migmartri June 13, 2023 14:19
@danlishka danlishka self-assigned this Jun 13, 2023
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

timeout: 1s
http_metrics:
addr: 0.0.0.0:5000
addr: 0.0.0.0:0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment explaining what this means.

@migmartri
Copy link
Member

Choose the random port for HTTP Metrics in the development mode to fix the already-in-use port issues on OSX, refs #155

Instead of ref you can use closes or fixes so the issue will get autoclosed

@danlishka danlishka merged commit 08adb57 into chainloop-dev:main Jun 13, 2023
@danlishka danlishka deleted the fix_http_metrics_on_osx branch June 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port 5000 is already in use on OS X
2 participants