Skip to content

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Jun 14, 2023

Attached integration-related commands were placed under workflow namespace.

This patch moves all those commands under integration attached ns. This makes it consistent with the rest of the integration-related commands and their life-cycles.

It also delete dependency-track commands since in the end by adding these namespaces we broke compatibility. I'll update the guides next.

$ go run main.go --insecure integration                                    
Third party integrations

Usage:
  chainloop integration [command]

Available Commands:
  attached    Integrations attached to workflows
  available   Integrations available in the controlplane ready to be registered
  registered  Integrations registered and configured in your Organization

Attached

$ go run main.go --insecure integration attached
Integrations attached to workflows

Usage:
  chainloop integration attached [command]

Available Commands:
  add         Attach an existing registered integration to a workflow
  delete      Detach an integration that's attached to a workflow
  list        List integrations attached to workflows

Registered

$ go run main.go --insecure integration registered
Integrations registered and configured in your Organization

Usage:
  chainloop integration registered [command]

Available Commands:
  add         Register a new instance of an integration
  delete      De-register an integration
  list        List registered integrations

Available

$ go run main.go --insecure integration available 
Integrations available in the controlplane ready to be registered

Usage:
  chainloop integration available [command]

Available Commands:
  describe    Describe integration
  list        List available integrations

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested a review from danlishka June 14, 2023 14:30
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@migmartri migmartri merged commit 0311143 into chainloop-dev:main Jun 14, 2023
@migmartri migmartri deleted the move-attachment-cli branch June 14, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants