Skip to content

Conversation

javirln
Copy link
Member

@javirln javirln commented Apr 2, 2025

Apparently there was a lot of changes regarding code generation. Probably because of a lack of rebase in the most recent PR.

Last night, the JSON schema plugin generator was upgraded to v0.3.0, introducing changes that altered our current generation process. For now, I’ve pinned it to the previous version v0.2.0 until we assess the impact.

@javirln javirln requested review from migmartri and jiparis April 2, 2025 07:23
@javirln javirln self-assigned this Apr 2, 2025
@migmartri
Copy link
Member

is this with the latest version of the generators? make init?

@javirln
Copy link
Member Author

javirln commented Apr 2, 2025

is this with the latest version of the generators? make init?

Yes, I've ran both make init and make init-api-tools and then both make api and make generate

Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javirln

Do we know when the changes were introduced? Did we skip the CI check by any chance?

Just to make sure we have pinned tooling and ci guardrails

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
Copy link
Member Author

javirln commented Apr 2, 2025

Thanks @javirln

Do we know when the changes were introduced? Did we skip the CI check by any chance?

Just to make sure we have pinned tooling and ci guardrails

It was the upgrade of the json schema generator that was not pinned. I've just pinned it.

@javirln javirln merged commit 9b554da into chainloop-dev:main Apr 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants