-
Notifications
You must be signed in to change notification settings - Fork 38
chore(install): Modify install.sh to support new GitHub release artifacts #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
In those examples I can't see testing loading an old version, for example
Does it work? |
VERSION="" | ||
FORCE_VERIFICATION=false | ||
INSTALL_PATH=/usr/local/bin | ||
PUBLIC_KEY_URL="https://raw.githubusercontent.com/chainloop-dev/chainloop/01ad13af08950b7bfbc83569bea207aeb4e1a285/docs/static/cosign-releases.pub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, are we still signing the binaries with a private key? I thought we moved to fulcio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are still signing all the output of goreleaser with a private key, see here:
chainloop/.github/workflows/release.yaml
Line 99 in 2a284f1
COSIGN_KEY: ${{ secrets.COSIGN_KEY }} |
I thought we moved to fulcio?
About the fulcio thingy, I cannot comment, I really don't know about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to create an issue about it
Yes sure, here's a few examples:
And with a way older version:
|
This patch updates the
install.sh
script to support both legacy and modern GitHub release formats for the Chainloop CLI.In newer releases (starting from version
v1.0.0-rc.3
), the CLI is distributed as a plain binary without a version in the filename and without a.tar.gz
archive. The script now detects whether a given release is legacy or modern and downloads the appropriate artifact accordingly—either the.tar.gz
archive for older versions or the standalone binary for newer ones.For modern releases, the latest version can be downloaded using the following URL:
Please note that legacy and modern GitHub releases referrers to the way Chainloop pushes artifacts to GitHub's releases.
Examples:
Regular installation (legacy)
New installations (being force by modifying the code since there are not new releases yet):
Forcing a specific version of the CLI:
Legacy
New installations (being force by modifying the code since there are not new releases yet) forcing a version: