Skip to content

docs: update docs references and remove old code #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

docs: update docs references and remove old code #1998

merged 1 commit into from
Apr 23, 2025

Conversation

migmartri
Copy link
Member

Remove old docs source code and update readme references

@migmartri
docs: update docs references and remove old code
359defb 
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
@migmartri migmartri requested review from danlishka and javirln April 23, 2025 20:29
danlishka
danlishka approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri migmartri merged commit 31eac55 into chainloop-dev:main Apr 23, 2025
13 checks passed
@migmartri migmartri deleted the remove-docs branch April 23, 2025 21:48
@BrewTestBot BrewTestBot mentioned this pull request May 5, 2025
Merged
@dmarkstedt
Copy link

This commit removed docs/static/install.sh which is still referenced in the getting started instructions on the project README.md. Was the removal of the script a mistake, or do you have a new installation method now?

https://github.com/chainloop-dev/chainloop?tab=readme-ov-file#getting-started

@migmartri
Copy link
Member Author

migmartri commented Jun 17, 2025 •
edited
Loading

This commit removed docs/static/install.sh which is still referenced in the getting started instructions on the project README.md. Was the removal of the script a mistake, or do you have a new installation method now?

https://github.com/chainloop-dev/chainloop?tab=readme-ov-file#getting-started

this is definitely a mistake, let me put it back, my bad.

The alternative way of finding the installation script is via

https://dl.chainloop.dev/cli/install.sh

as you can see here

@migmartri migmartri mentioned this pull request Jun 17, 2025
Merged
@migmartri
Copy link
Member Author

This commit removed docs/static/install.sh which is still referenced in the getting started instructions on the project README.md. Was the removal of the script a mistake, or do you have a new installation method now?

https://github.com/chainloop-dev/chainloop?tab=readme-ov-file#getting-started

@dmarkstedt the readme has been updated, thanks for the report #2114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlishka danlishka danlishka approved these changes

@javirln javirln Awaiting requested review from javirln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@migmartri @dmarkstedt @danlishka