feat(rbac): refactor membership data to support polymorphic memberships #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
approved these changes
Jun 16, 2025
|
|
||
| func (Membership) Edges() []ent.Edge { | ||
| return []ent.Edge{ | ||
| // Deprecated: use polymorphic membership instead |
There was a problem hiding this comment.
how difficult do you think it would be to kill those columns?
I am ok if we keep it in multiple steps though
There was a problem hiding this comment.
I think I can create an additional migration for it, but in a different version, not to break compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new database fields (MembershipType, MemberID, ResourceType and ResourceID) to support flexible RBAC schemas at different levels (organizations, projects) using different role sources (users, groups, teams...).
The data layer logic has been updated to maintain the current behaviour. A migration is also included.