Skip to content

fix(cli): improve runs wording #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix(cli): improve runs wording #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/cli/cmd/attestation_reset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ func newAttestationResetCmd() *cobra.Command {
return newGracefulError(err)
}

logger.Info().Msg("Attestation canceled")
msg := "Attestation canceled"
if trigger == triggerFailed {
msg = "Attestation marked as failed"
}

logger.Info().Msg(msg)

return nil
},
Expand Down
15 changes: 14 additions & 1 deletion app/cli/internal/action/workflow_run_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,26 @@ func (action *WorkflowRunList) Run(opts *WorkflowRunListOpts) (*PaginatedWorkflo
return res, nil
}

func humanizedRunStatus(in pb.RunStatus) string {
mapping := map[pb.RunStatus]string{
pb.RunStatus_RUN_STATUS_UNSPECIFIED: "unspecified",
pb.RunStatus_RUN_STATUS_INITIALIZED: "in progress",
pb.RunStatus_RUN_STATUS_SUCCEEDED: "success",
pb.RunStatus_RUN_STATUS_FAILED: "failed",
pb.RunStatus_RUN_STATUS_CANCELLED: "canceled",
pb.RunStatus_RUN_STATUS_EXPIRED: "expired",
}

return mapping[in]
}

func pbWorkflowRunItemToAction(in *pb.WorkflowRunItem) *WorkflowRunItem {
if in == nil {
return nil
}

item := &WorkflowRunItem{
ID: in.Id, State: in.State, Reason: in.Reason, CreatedAt: toTimePtr(in.CreatedAt.AsTime()),
ID: in.Id, State: humanizedRunStatus(in.GetStatus()), Reason: in.Reason, CreatedAt: toTimePtr(in.CreatedAt.AsTime()),
Workflow: pbWorkflowItemToAction(in.Workflow),
RunURL: in.GetJobUrl(),
RunnerType: humanizedRunnerType(in.GetRunnerType()),
Expand Down
Loading