-
Notifications
You must be signed in to change notification settings - Fork 38
chore(groups): Initial implementation of user groups #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b577ef
to
4ddb8b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you didn't push yet the membership part, right?
// Optional filter to search by group description | ||
optional string description = 2; | ||
// Optional filter to search by member email address | ||
optional string member_email = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to search groups where this person is a member?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @javirln added some comments inline, but in general lgtm
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
38baefc
to
39bf72b
Compare
No, the membership management will come in the next PR I have ready that depends on this one. |
@jiparis @migmartri with regard the comment on what's the filter about email user. That's indeed to search the groups a member is part of. Conbined with the filter about maintainers, we can perform look ups to know the groups a specific person is part of. I've added because it seems reasonable to me to be honest and can be useful for admins/owners. |
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
This patch introduces a new service, GroupService, with several endpoints for managing groups within the system. For now, it includes a basic implementation of CRUD operations and the ability to list members within a group. Member management (adding/removing users) will be handled in a separate PR as well as CLI changes.
It includes:
Ref: #2120