feat(api-tokens): project level tokens CRUD #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
jiparis
reviewed
Jun 26, 2025
Comment on lines
+271
to
+272
| PolicyProjectAPITokenCreate, | ||
| PolicyProjectAPITokenRevoke, |
There was a problem hiding this comment.
Should these two be enabled for Project Viewers? They could escalate privileges, right?
There was a problem hiding this comment.
they are not, I think Github is messing with the visualization
| } | ||
|
|
||
| return entAPITokenToBiz(token), nil | ||
| return r.FindByID(ctx, token.ID) |
There was a problem hiding this comment.
Why is this additional query needed?
There was a problem hiding this comment.
To make sure the resulting object contains the information about the project and org
migmartri
changed the title
migmartri
changed the title
|
@jiparis this is ready for review |
jiparis
approved these changes
Jun 26, 2025
Comment on lines
+271
to
+272
| PolicyProjectAPITokenCreate, | ||
| PolicyProjectAPITokenRevoke, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2130