feat(RBAC): enable project-scoped API tokens #2143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
changed the title
jiparis
reviewed
Jun 27, 2025
| // If a project is provided, we store it in the token | ||
| var projectID *uuid.UUID | ||
| if options.project != nil { | ||
| projectID = ToPtr(options.project.ID) |
There was a problem hiding this comment.
doesn't &options.project.ID work?
There was a problem hiding this comment.
it does, I was just using one way of doing it tbh, a little bit pointless it's true
jiparis
approved these changes
Jun 27, 2025
jiparis
reviewed
Jun 27, 2025
| Name: token.Name, | ||
| CreatedAt: token.CreatedAt, | ||
| Token: token.JWT, | ||
| ProjectID: token.ProjectID, |
There was a problem hiding this comment.
If the token has a ProjectID, is this change checking that the ProjectID in the database is the same?
There was a problem hiding this comment.
mm, it is not, let me add it
There was a problem hiding this comment.
Good catch, I was using the projectID from the DB when in reality we need to use the one from the token.
Now I check that both match
That's correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues with project-scoped API tokens #2130
I tested it locally performing both attestations and regular operations with admin tokens or scoped tokens, for example this is what you get when you try to perform an attestation with a token from another project.
closes #2130