Skip to content

feat(projects): Allow to include users to projects #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

feat(projects): Allow to include users to projects #2152

merged 2 commits into from
Jul 1, 2025

Conversation

javirln
Copy link
Member

@javirln javirln commented Jun 30, 2025 •
edited
Loading

This patch introduces support for managing users within a project. Key changes include:

  • New API endpoints:
    • ListMembers to list all members is a project
    • AddMember to add users to a project
    • RemoveMember to remove users from a project
  • Audit logging for membership changes
  • Extended test coverage to include the new endpoints
  • Service-level refactor to use a generic IdentityReference for project-related requests

Permissions matrix:

  • Admins and Owners have full access to group and membership operations
  • Only Admins, Owners, and Project Admins can add or remove members

Pending:

  • Allow to add groups to projects

@javirln javirln self-assigned this Jun 30, 2025
@javirln javirln requested review from jiparis and migmartri and removed request for jiparis June 30, 2025 14:34
migmartri
migmartri approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javirln, let's wait for a check from @jiparis on RBAC just in case.

@javirln
feat(projects): Allow to include users to projects
6aeeec3 
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln
fix resource type
b305147 
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
jiparis reviewed Jul 1, 2025
View reviewed changes
app/controlplane/internal/service/project.go Outdated
service: newService(opts...),
APITokenUseCase: uc,
apiTokenUseCase: apiTokenUseCase,
projectUseCase: projectUseCase,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProjectUseCase is already available as part of service

@javirln javirln merged commit bbb4d7b into chainloop-dev:main Jul 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migmartri migmartri migmartri approved these changes

@jiparis jiparis jiparis approved these changes

Assignees

@javirln javirln

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javirln @migmartri @jiparis