Skip to content

feat(deployment): Add support for GCP secret manager to Helm charts #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2023
Merged

feat(deployment): Add support for GCP secret manager to Helm charts #225

merged 6 commits into from
Jul 10, 2023

Conversation

gr0
Copy link
Collaborator

@gr0 gr0 commented Jul 8, 2023 •
edited by migmartri
Loading

A small PR adding support for the GCP secret manager to the Helm Charts.

refs #108

gr0 added 2 commits July 8, 2023 23:44
@gr0
Add GCP Secret Manager support to Helm Charts and update the README f…
ba2ab00 
…ile for deployment to reflect that

Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
@gr0
Update default values for the GCP secret manager in the Helm Chart
346b277 
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
@migmartri migmartri self-requested a review July 9, 2023 09:35
@migmartri migmartri mentioned this pull request Jul 9, 2023
Closed
2 tasks
migmartri
migmartri reviewed Jul 9, 2023
View reviewed changes
Copy link
Member

@migmartri migmartri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looking good.

Summarizing

a) take a look at the possible missing yaml key
b) update the example to include the missing --set stanza
c) bump the chart version to 1.7.1. That will re-package the chart as a new version once merged.

chainloop/deployment/chainloop/Chart.yaml

Line 7 in bfd154b

version: 1.7.0

Thanks!

@migmartri migmartri changed the title Add support for GCP secret manager to Helm charts feat(deployment): Add support for GCP secret manager to Helm charts Jul 9, 2023
gr0 added 3 commits July 10, 2023 18:47
@gr0
Update the README to include the --set for the secretsBackend.backend…
1db6e3e 
… property

Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
@gr0
Include the proper parent key for GCP Secret Manager in Helm Charts
c5bc3e7 
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
@gr0
Bump the Helm Chart version to 1.7.1
08fb488 
Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
@gr0
Copy link
Collaborator Author

gr0 commented Jul 10, 2023

@migmartri addressed the comments, have a look when you have time, thanks!

@gr0
Merge branch 'main' into rafal/add-support-for-gcp-secret-manager-to-…
81fc23f 
…helm-charts

Signed-off-by: Rafał Kuć <r.kuc@solr.pl>
migmartri
migmartri approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@migmartri migmartri merged commit 6f7e079 into chainloop-dev:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migmartri migmartri migmartri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gr0 @migmartri