Skip to content

chore: org viewers cannot become project admins #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 15, 2025
Merged

chore: org viewers cannot become project admins #2251

merged 12 commits into from
Jul 15, 2025

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented Jul 14, 2025

Org Viewers only have read-only permissions and don't participate in RBAC, so it's not consistent with ProjectAdmin role, which can manage resources.

jiparis added 2 commits July 14, 2025 14:32
@jiparis
org viewers cannot become project admins
bed46d8 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
fix condition and simplify method
3f5217d 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis requested review from migmartri and javirln July 14, 2025 12:57
jiparis
jiparis commented Jul 14, 2025
View reviewed changes
jiparis
jiparis commented Jul 14, 2025
View reviewed changes
jiparis added 5 commits July 14, 2025 15:31
@jiparis
remove newline
94c8e4c 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
remove incompatible combinations
49a8b55 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
fix
a0f80fd 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
fix
92474e7 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
fix condition
e446f01 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
jiparis
jiparis commented Jul 14, 2025
View reviewed changes
jiparis added 5 commits July 14, 2025 16:34
@jiparis
restore unrelated changes
bd77355 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
remove imports
1043654 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
restore unrelated changes
005fe7a 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
add comment
f9290b2 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis
fix tests
e4daa88 
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis merged commit df71cee into chainloop-dev:main Jul 15, 2025
13 checks passed
@jiparis jiparis deleted the PFM-3323-restrict-viewers branch July 15, 2025 09:12
migmartri added a commit to migmartri/chainloop that referenced this pull request Jul 15, 2025
@migmartri
Revert "chore: org viewers cannot become project admins (chainloop-de…
f6472b3 
…v#2251)"

This reverts commit df71cee.
migmartri added a commit to migmartri/chainloop that referenced this pull request Jul 15, 2025
@migmartri
Revert "chore: org viewers cannot become project admins (chainloop-de…
f8c0ecb 
…v#2251)"

This reverts commit df71cee.

Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri added a commit that referenced this pull request Jul 15, 2025
@migmartri
Revert "chore: org viewers cannot become project admins (#2251)" (#2262)
fc7fb43 
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
@jiparis jiparis mentioned this pull request Jul 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javirln javirln javirln approved these changes

@migmartri migmartri Awaiting requested review from migmartri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiparis @javirln