fix(group): Created at when listing project for groups #2252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
approved these changes
Jul 14, 2025
| optional string latest_version_id = 5; | ||
| // Timestamp when the project was created | ||
| // Timestamp when the membership was created | ||
| google.protobuf.Timestamp created_at = 6; |
There was a problem hiding this comment.
this is strange, projectInfo is a generic message no? We might need something else. Like ProjectMembership?
There was a problem hiding this comment.
We have ProjectMember.
That represents the members of a Project. This is the other way around, the projects a group is member of. This ProjectInfo represents detailed information about a project that a group is a member of. We could call it GroupProjectMembership for example
There was a problem hiding this comment.
Yeah, probably call it smth less confusing, unless this is nested inside the response, is it?
jiparis
approved these changes
Jul 15, 2025
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the
created_atof theProjectInfoso it contains when the membership between the group and the project was created not when the project was created.