feat(policy): change devel commands return to stdout #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
migmartri
requested changes
Aug 5, 2025
app/cli/cmd/policy_develop_lint.go
Outdated
| return nil | ||
| } | ||
|
|
||
| fmt.Fprintf(os.Stdout, "Found %d issues:\n", len(result.Errors)) |
migmartri
reviewed
Aug 5, 2025
| *action.AttestationStatusMaterial | | ||
| *action.ListMembershipResult | ||
| *action.ListMembershipResult | | ||
| *action.PolicyEvalResult |
There was a problem hiding this comment.
does this mean that now we support json output?
There was a problem hiding this comment.
Correct, the text version didn't follow any structure so it would cause problems later on
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
migmartri
approved these changes
Aug 5, 2025
migmartri
approved these changes
Aug 5, 2025
| logger.Error().Msg(err) | ||
| } | ||
| return fmt.Errorf("policy validation failed with %d issues", len(result.Errors)) | ||
| return encodeResult(result) |
There was a problem hiding this comment.
what's the output when we do not have any violations? Do we return an empty violations array?
There was a problem hiding this comment.
Yes, here's the output
[
{
"violations": [],
"skip_reasons": [],
"skipped": false
}
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes policy evaluation and linting output to support proper redirection (e.g.,
chainloop policy devel eval {flags} > results.json).