Skip to content

fix(release): do not fail if we can not attest a material #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix(release): do not fail if we can not attest a material #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9d8fb5
fix(release): do not fail if we can not attest a material
migmartri Jul 10, 2023
fe309c4
feat: add plugin
migmartri Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/contracts/releases.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ materials: [
{type: "ARTIFACT", name: "cli-linux-amd64", output: true},
{type: "ARTIFACT", name: "control-plane-linux-amd64", output: true},
{type: "ARTIFACT", name: "artifact-cas-linux-amd64", output: true},
{type: "ARTIFACT", name: "chainloop-plugin-discord-webhook-linux-amd64"},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also apply this change in the contract so we also attest this binary.

// Container images
{type: "CONTAINER_IMAGE", name: "control-plane-image", output: true},
{type: "CONTAINER_IMAGE", name: "artifact-cas-image", output: true},
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,11 @@ jobs:
run: |
# Binaries x86_64
# TODO: add the rest of binaries
# NOTE that we are not making the attestation fail if the material is not found. We will fail on "att push"
echo -n '${{ steps.release.outputs.artifacts }}' | jq -r '.[] | select(.type=="Binary" and .goos=="linux" and .goarch=="amd64") | { "name": "\(.extra.ID)-\(.goos)-\(.goarch)", "path":"\(.path)"} | @base64' | while read i; do
BINARY_NAME=$(echo "${i}" | base64 --decode | jq -r ${1} .name)
BINARY_PATH=$(echo "${i}" | base64 --decode | jq -r ${1} .path)
chainloop attestation add --name ${BINARY_NAME} --value ${BINARY_PATH}
chainloop attestation add --name ${BINARY_NAME} --value ${BINARY_PATH} || true
done

- name: Finish and Record Attestation
Expand Down