Skip to content

feat(policy): update output handling for lint and eval #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 11, 2025
Merged

feat(policy): update output handling for lint and eval #2316

merged 10 commits into from
Aug 11, 2025

Conversation

Piskoo
Copy link
Collaborator

@Piskoo Piskoo commented Aug 7, 2025

This PR makes some changes to how output from policy devel tools is displayed:

  • lint works with the output flag while maintaining exit errors
  • indentation in yaml policy files uses 2 spaces after it was formated with --format flag
  • eval violations returned from regal are now split correctly and displayed one by one
  • eval violation concerning file formatting points to --format flag instead of opa fmt

Closes #2283

Piskoo added 4 commits August 6, 2025 15:51
@Piskoo
fix yaml indentation after format; update regal violation error proce…
174240a 
…ssing

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo
add handler for output flag to lint
69f4cb8 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo
add exit codes to lint
ce7a03a 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo
fix exit codes
fbb9356 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo Piskoo requested review from javirln, jiparis and migmartri August 7, 2025 08:55
@Piskoo Piskoo marked this pull request as ready for review August 7, 2025 08:55
@migmartri
Copy link
Member

Is this solving by any chance #2320 ?

jiparis
jiparis reviewed Aug 7, 2025
View reviewed changes
jiparis
jiparis requested changes Aug 7, 2025
View reviewed changes
Copy link
Member

@jiparis jiparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please check my comments.

@Piskoo
update identation handling; add comments
36aca8a 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
jiparis
jiparis reviewed Aug 8, 2025
View reviewed changes
Piskoo added 2 commits August 11, 2025 09:31
@Piskoo
remove error wrapper for violations
294c665 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo
fix linter
d63546d 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@jiparis jiparis self-requested a review August 11, 2025 09:14
jiparis
jiparis reviewed Aug 11, 2025
View reviewed changes
Piskoo added 3 commits August 11, 2025 17:06
@Piskoo
cast error instead of regex matching
d659c5b 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo
chore: resolve merge conflicts
0a7c126
@Piskoo
fix linter
e68d26f 
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@jiparis
Copy link
Member

jiparis commented Aug 11, 2025

Thanks @Piskoo I've been testing the latest changes and everything looks good now. Much cleaner, thanks!!

@migmartri migmartri merged commit ecce569 into chainloop-dev:main Aug 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migmartri migmartri migmartri approved these changes

@jiparis jiparis jiparis approved these changes

@javirln javirln Awaiting requested review from javirln

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(policy): update output handling for lint and eval

3 participants

@Piskoo @migmartri @jiparis