Skip to content

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Jul 13, 2023

Enable upx compression during build.

On my local tests there is a reduction of about half the size, for example

$ upx bin/control-plane
                       Ultimate Packer for eXecutables
                          Copyright (C) 1996 - 2023
UPX 4.0.2       Markus Oberhumer, Laszlo Molnar & John Reiser   Jan 30th 2023

        File size         Ratio      Format      Name
   --------------------   ------   -----------   -----------
  59908290 ->  28271904   47.19%   linux/amd64   control-plane           

The discord plugin size went to 1/4 of the size. 12MB to 3MB

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested a review from danlishka July 13, 2023 20:50
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this kind of low-hanging fruit.

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri merged commit d6e7b66 into chainloop-dev:main Jul 14, 2023
@migmartri migmartri deleted the add-upx branch July 14, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants