feat(controlplane): soft-delete CAS backends #242
Conversation
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
| } | ||
|
|
||
| // Delete the CAS backend | ||
| func (s *CASBackendService) Delete(ctx context.Context, req *pb.CASBackendServiceDeleteRequest) (*pb.CASBackendServiceDeleteResponse, error) { |
There was a problem hiding this comment.
Should we then call it soft delete or archive? I am not sure I am following. We give an option to the end user to delete but we soft delete instead. Why don't we call it properly? Am I missing anything?
There was a problem hiding this comment.
To me, soft-deletion is an implementation detail of the system. The fact that it does not remove it from the DB is not something that the user should know about, unless we plan to offer a recovery mechanism.
The reason we do not want to hard delete is because in the future we might need that data to get historical information on where an artifact was placed.
WDYT?
There was a problem hiding this comment.
ok. It means that once we delete we are not allowing them to download evidences via cli, but attestations visible in workflow runs and maybe you can see references to the deleted backend so you know where to find the a given material?
There was a problem hiding this comment.
ok. It means that once we delete we are not allowing them to download evidences via cli, but attestations visible in workflow runs and maybe you can see references to the deleted backend so you know where to find the a given material?
for now yes, but the idea would be that once an user knows an artifact digest, these scenarios could happen:
the artifact with that digest...
1 - is in the default CAS backend
2 - is in a non-default CAS backend
3 - is in a (soft) deleted CAS backend
4 - is in one of the above but credentials are wrong
5 - none of the above
Today, we only support the first option. 2 and 3) will be implemented with a combination of a) digest <-> backend mapping + b) soft-deleted cas backend retrieval.
Soft delete CAS backends with confirmation in the client side if it's the default one.
Refs #223