Skip to content

fix(cli): return consistent authentication error #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix(cli): return consistent authentication error #2450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/cli/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,14 @@ func errorInfo(err error, logger zerolog.Logger) (string, int) {
return msg, exitCode
}

func isWrappedErr(grpcStatus *status.Status, err *errors.Error) bool {
target := errors.FromError(grpcStatus.Err())
// target is the expected error
// grpcStatus is the actual error that might be wrapped in both the status and the error
func isWrappedErr(grpcStatus *status.Status, target *errors.Error) bool {
err := errors.FromError(grpcStatus.Err())
// The error might be wrapped since the CLI sometimes returns a wrapped error
if errors.Is(err, target) {
return true
}

return target.Code == err.Code && err.Message == target.Message
}
Loading