Skip to content

Conversation

danlishka
Copy link
Member

@danlishka danlishka commented Jul 20, 2023

There is an option to skip the creation of the Robot Account --skip-robot-account-create
Screenshot 2023-07-20 at 11 31 19

When you create a workflow with the output parameter set to json. There are new fields: robotAccountKey and robotAccountID.
Screenshot 2023-07-20 at 11 32 14

This is how the table look like with the default table view:
Screenshot 2023-07-20 at 11 32 54

Closes #90

Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I added two comments, mainly about

  • Making sure that we do not pollute the workflow struct for just rendering at creation
  • Maybe return the default output for the robot-account

WDYT?


cmd.Flags().BoolVarP(&skipRACreate, "skip-robot-account-create", "s", false, "Skip creating a Robot Account for this workflow.")

cmd.Flags().SortFlags = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about this option. Why did you disable it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because if you don't, this is sorted and some options are shown below skip-robot...

@migmartri migmartri changed the title Robot Account automatically created during the workflow creation feat(cli): robot Account automatically created during the workflow creation Jul 20, 2023
@migmartri migmartri changed the title feat(cli): robot Account automatically created during the workflow creation feat(cli): robot account automatically created during the workflow creation Jul 20, 2023
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
@danlishka danlishka force-pushed the robot_account_autocreated branch from 8ed4a38 to 450c8ec Compare July 20, 2023 13:56
@danlishka danlishka merged commit 9054ebc into chainloop-dev:main Jul 20, 2023
@danlishka danlishka deleted the robot_account_autocreated branch July 20, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create first robot-account during workflow creation
2 participants