Skip to content

Conversation

migmartri
Copy link
Member

If during the integrations dispatch process one of the integrations can't find the credentials external dependency, it gets skipped instead of failing the execution.

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested a review from danlishka July 28, 2023 08:25
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok for now but we should build a better defined log + chainloop operator notifications in the future to let the admin or a person who added an integration know

@migmartri migmartri merged commit e1672fa into chainloop-dev:main Jul 29, 2023
@migmartri migmartri deleted the 252-annotations branch July 29, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants