-
Notifications
You must be signed in to change notification settings - Fork 38
feat: custom annotations #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
What about the root-level annotations? For instance, in your example I would rather use:
Then I would display the root-level annotations at the top in the CLI output and in notifications. What do you think? |
Right, that example I put might not be the right one. High level annotations will not work in the scenario a, which is for example what we use in our go-release release process https://github.com/chainloop-dev/chainloop/blob/main/.github/workflows/contracts/releases.cue The single release process contains artifacts from different components, having only top level annotations will effectively force us to do more than one attestation in the same job. I see top-level annotations complementary to this feature because of the reasons you laid of in your case (using custom materials to add context). Does it make sense? |
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
cc/ @gr0 since you might be interested in this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Great stuff, thank you @migmartri 🙇 |
This patch is the first step towards #252, it allows the definition of key/val annotations in the contract for the different materials.
These annotations are then injected in the attestation automatically and shown in the output
For example, having this contract
A resulting attestation will look like
The summary output has also been improved to show the custom annotations but also handle better the horizontal viewport by
The next steps would be to 1) use such annotations in the dependency-track plugin to solve scenario "a" and 2) allow setting these annotation at runtime.