fix(deployment): properly expose service account key for secret manager #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaibon
force-pushed
the
gcp-sercret-manager-helm
branch
2 times, most recently
from
858cf4f to
26f087d
Compare
zaibon
force-pushed
the
gcp-sercret-manager-helm
branch
2 times, most recently
from
a250ff5 to
338baad
Compare
migmartri
reviewed
Aug 14, 2023
migmartri
approved these changes
Aug 14, 2023
We need to mount the service account key as a file into the controlplane and cas container when using GCP secret manager. - use proper key in sercret manager service account configuration - update helm chart README - be consitent in chart template and use 'serviceaccountkey' everywhere Signed-off-by: Christophe de Carvalho <christophe@archipelo.co>
zaibon
force-pushed
the
gcp-sercret-manager-helm
branch
from
338baad to
e470134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to mount the service account key as a file into the controlplane container when using GCP secret manager.
Fixes #295