feat(deployment): allow to configure annotations of controlplane service #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The CI seems to be complaining, please take a look at the DCO (signed off) requirement, thanks! |
migmartri
approved these changes
Aug 18, 2023
this is required in GKE to be able to configure custom backend healthcheck on this service. Signed-off-by: Christophe de Carvalho <christophe@archipelo.co>
zaibon
force-pushed
the
controlplane-service-annotations
branch
from
1b93c0e to
28d348f
Compare
Signed-off-by: Christophe de Carvalho <christophe@archipelo.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is required in GKE to be able to configure custom backend healthcheck on this service.