Skip to content

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Aug 30, 2023

  • Exposes secret_prefix again fixing the regression. It does it by bubbling it up to the parent struct.
  • Adds role property to initializer and use it in the vault client to check read or write permissions.

NOTE: These issues were noticed when connecting to a production instance of vault and realized that the a policy I created wasn't working since the system was trying to push secrets to a different path.

Closes #315

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested review from danlishka and gr0 August 30, 2023 21:38
@migmartri migmartri self-assigned this Aug 30, 2023
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri marked this pull request as ready for review August 30, 2023 22:27
@migmartri migmartri merged commit 0293a89 into chainloop-dev:main Aug 31, 2023
@migmartri migmartri deleted the fix-secret-prefix branch August 31, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret-prefix is not being propagated
2 participants