Skip to content

Conversation

zaibon
Copy link
Contributor

@zaibon zaibon commented Aug 31, 2023

The helm chart now allows to specify a sercret name where a TLS certificate and key are store. If specified, it mounts the secret in the pods and update the configuration to enable TLS on the servers.

@@ -180,6 +180,9 @@
         addr: 0.0.0.0:8000
         timeout: 1s
       grpc:
+        tls_config:
+          certificate: /data/server-certs/tls.crt
+          private_key: /data/server-certs/tls.key
         addr: 0.0.0.0:9000
         timeout: 1s
       http_metrics:
@@ -209,6 +212,9 @@
       grpc:
         addr: 0.0.0.0:9000
         timeout: 10s
+        tls_config:
+          certificate: /data/server-certs/tls.crt
+          private_key: /data/server-certs/tls.key
     cas_server:
       grpc:
         addr: foo-chainloop-cas-api:80
@@ -390,6 +396,8 @@
               mountPath: "/tmp"
             - name: gcp-secretmanager-serviceaccountkey
               mountPath: /gcp-secrets
+            - name: server-certs
+              mountPath: /data/server-certs
       volumes:
         - name: config
           projected:
@@ -401,6 +409,9 @@
         - name: jwt-public-key
           secret:
             secretName: foo-chainloop-cas-jwt-public-key
+        - name: server-certs
+          secret:
+            secretName: server_certs
         - name: gcp-secretmanager-serviceaccountkey
           secret:
             secretName: foo-chainloop-controlplane-gcp-secretmanager-serviceaccountkey
@@ -504,6 +515,8 @@
               mountPath: /tmp
             - name: jwt-cas-private-key
               mountPath: /secrets
+            - name: server-certs
+              mountPath: /data/server-certs
             - name: gcp-secretmanager-serviceaccountkey
               mountPath: /gcp-secrets
       volumes:
@@ -520,6 +533,9 @@
         - name: jwt-cas-private-key
           secret:
             secretName: foo-chainloop-controlplane-jwt-cas
+        - name: server-certs
+          secret:
+            secretName: server_certs
         - name: gcp-secretmanager-serviceaccountkey
           secret:
             secretName: foo-chainloop-controlplane-gcp-secretmanager-serviceaccountkey

Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly good to me, ptal at my feeback and let me know your thoughts.

Thanks a lot, this is great work!

Also, note that your PR is still in draft state, just in case you forgot to change its state.

The helm chart now allows to specify a sercret name where a TLS certificate and key are store.
If specified, it mounts the secret in the pods and update the configuration to enable TLS on the servers.

Signed-off-by: Christophe de Carvalho <christophe@archipelo.co>
@zaibon zaibon marked this pull request as ready for review August 31, 2023 18:11
@migmartri migmartri merged commit 9efb869 into chainloop-dev:main Aug 31, 2023
@zaibon zaibon deleted the grpc_tls_helm branch September 1, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants