Skip to content

fix: show downloading message during redirect #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix: show downloading message during redirect #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa549ad
fix: show downloading message during redirect
migmartri Sep 5, 2023
f7a93ba
fix: show downloading message during redirect
migmartri Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/controlplane/internal/service/casredirect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,14 @@ func (s *CASRedirectService) HTTPDownload(ctx khttp.Context) error {
}

// perform redirect
http.Redirect(ctx.Response(), ctx.Request(), urlResponse.Result.Url, http.StatusTemporaryRedirect)
// In order ton show a redirect message in the page before the redirection,
// we need to use a Refresh Header instead of a vanilla redirect (via location change)
// We want to show a message because in some cases the download will be shown as downloadable and hence
// the UX for the user is like the browser got stuck
ctx.Response().Header().Set("Refresh", "1;url="+urlResponse.Result.Url)
ctx.Response().WriteHeader(http.StatusFound)
fmt.Fprintln(ctx.Response(), "Your download will begin shortly...")

return nil
}

Expand Down