Skip to content

feat(api): get workflowRuns by digest #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2023
Merged

feat(api): get workflowRuns by digest #344

merged 3 commits into from
Sep 15, 2023

Conversation

migmartri
Copy link
Member

Updates the controlplane WorkflowRun API with

  • Parameter to retrieve the workflowRun by attestation digest
  • The controller code now takes into account if a workflow is public

@migmartri
feat(api): get workflowRuns by digest
4268161 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
chore: add index to attestation digest
d67d629 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
chore: add tests
2dfcde2 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
danlishka
danlishka approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri migmartri merged commit 899e81d into chainloop-dev:main Sep 15, 2023
@migmartri migmartri deleted the public-workflow-runs branch September 15, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlishka danlishka danlishka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@migmartri @danlishka