refactor(CAS proxy): multiple CAS backend providers support #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
changed the title
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Sep 26, 2023
| issues: | ||
| exclude-rules: | ||
| - path: _test\.go | ||
| text: "Potential hardcoded credentials" |
There was a problem hiding this comment.
for some reason now it complains about some of the sha256 digests that we are using during testing
| message InfozResponse { | ||
| string version = 1; | ||
| string version = 1; | ||
| repeated string backends = 2; |
There was a problem hiding this comment.
this is in fact the new part. It exposes the enabled backends.
| backend.Providers | ||
| } | ||
|
|
||
| func loadCASBackendProviders(creader credentials.Reader) backend.Providers { |
There was a problem hiding this comment.
the new dynamic loader
danlishka
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to dynamically select a backend provider in the CAS proxy
This is a prerequisite of #357, once merged we will be able to implement a new backend in CAS + enable it in the controlplane