Skip to content

chore: remove OCI registry plugin #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore: remove OCI registry plugin #372

merged 1 commit into from
Oct 4, 2023

Conversation

migmartri
Copy link
Member

This PR removes the OCI registry fanout plugin, the reason being:

  • It overlaps with the concept if CAS backend, in fact now that we support more advanced (and multiple) cas backends, this plugin makes less sense.
  • Unlike CAS backends, it only stores attestations, not materials
  • It doesn't store anywhere the result of the upload

@migmartri
chore: remove OCI registry plugin
e891a5c 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested a review from danlishka September 28, 2023 16:43
danlishka
danlishka approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@migmartri migmartri merged commit af920e3 into chainloop-dev:main Oct 4, 2023
@migmartri migmartri deleted the remove-oci branch October 4, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlishka danlishka danlishka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@migmartri @danlishka