Skip to content

fix(cas): handle client cancellation #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(cas): handle client cancellation #378

merged 1 commit into from
Oct 4, 2023

Conversation

migmartri
Copy link
Member

Context cancellation during upload chunk fills was not handled properly.

This code

  • Makes sure that having an error always returns regardless of the type
  • Handles the grpc cancellation so we don't get cancellation exceptions

Fixes #377

@migmartri
fix(cas): handle client cancellation
3da2f28 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested a review from danlishka October 4, 2023 20:31
danlishka
danlishka approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri migmartri merged commit fd2c59e into chainloop-dev:main Oct 4, 2023
@migmartri migmartri deleted the upload-error branch October 4, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlishka danlishka danlishka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upload error during stress testing
2 participants
@migmartri @danlishka