feat(attestation): add annotations to subject materials #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
buccarel
reviewed
Oct 24, 2023
| "sha256": "580ac09da7771920dfd0c214964e7bfe4c27903bcbe075769a4044a67c9a390a" | ||
| } | ||
| }, | ||
| "annotations": { |
There was a problem hiding this comment.
[not blocking / just a consideration]
Is it expected to have a JSON key in plural which value is not an array? In this case, it's annotations, meaning that 1 annotation is <key, value> in that hash.
There was a problem hiding this comment.
Yes, it's part of the in-toto spec upstream.
In fact, it seems that a key-value pair is what makes indeed one annotation.
buccarel
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate material annotations to subject structs. This will enable enhanced ingestion upstream.
In another patch, a similar feature #383 will be handled for our custom git head subject.