Skip to content

chore: refactor uploader interface #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

chore: refactor uploader interface #41

merged 1 commit into from
Mar 17, 2023

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Mar 17, 2023 •
edited
Loading

Follow up on the required refactoring for #2

  • Extract GRPC connection initialization, since now it will be used also from the control plane not just from the CLI
  • Moved the casClient additional structures, i.e progressStatus to the actual casClient

@migmartri
chore: refactor uploader interface
5d2477e 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri marked this pull request as ready for review March 17, 2023 14:18
@migmartri migmartri merged commit 29d39b9 into chainloop-dev:main Mar 17, 2023
@migmartri migmartri deleted the connect-cas branch March 17, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@migmartri